cache data columns with missing parent - #157
Merged
Merged
Conversation
vladimir-ea
force-pushed
the
ve/column_cache
branch
from
August 3, 2026 15:25
1cc7cd2 to
99b3429
Compare
added 9 commits
August 4, 2026 12:13
ninaiiad
reviewed
Aug 5, 2026
ninaiiad
reviewed
Aug 5, 2026
| "sidecar parent_root not yet validated — ignoring (not penalized)" | ||
| ); | ||
| return ColumnOutcome::Skip; | ||
| return ColumnOutcome::AwaitParent { parent_root: *parent_root }; |
Collaborator
There was a problem hiding this comment.
if we do cache these now, maybe we should do signature verification first? to filter out invalid data
Collaborator
Author
There was a problem hiding this comment.
we do signature verification once per block and then its the last check after everything else - so these cached entries would fail validation when the parent block is available - not sure it is worth verifying up front?
Comment on lines
+654
to
+656
| self.validate_gloas_column(stream_id, buf, gossip_subnet) | ||
| } else { | ||
| self.validate_fulu_column(stream_id, buf, gossip_subnet, None) |
Collaborator
There was a problem hiding this comment.
these have been run before caching already I think?
Collaborator
Author
There was a problem hiding this comment.
parent check at least needs to be re-run - will need to re-jig this
added 2 commits
August 5, 2026 18:12
ninaiiad
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few different fixes related to syncing / following: